Add node_pool to arohcp #1017
Draft
Add node_pool to arohcp #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alba Hita Catala <[email protected]>
ahitacat
force-pushed
the
add-nodepool-arohcp
branch
from
14668c8 to
8b93cdb
Compare
nimrodshn
reviewed
Jan 30, 2025
|
|
||
| // Deletes the node pool. | ||
| method Delete { | ||
| } |
There was a problem hiding this comment.
Lets keep this with Get only and add methods later.
There was a problem hiding this comment.
I resolved this, but I think it is not needed to remove the rest of the methods. We can hold this PR until we have the endpoints ready.
nimrodshn
reviewed
Jan 30, 2025
|
don't we also need to fix the reference in the cluster resource? |
No. the compiler knows how to find it if it exists in its service. [e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.